Requested JsHelper buffer #156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
February 28, 2011 11:54
|
Sorry, only the last commit is to be taken into account : PathMotion@4d9afe8 I don't know how to put only this one here :/ |
| @@ -223,7 +223,7 @@ class DataSource extends Object { | |||
| * @return array Array of sources available in this datasource. | |||
| * @access public | |||
| */ | |||
| function listSources($data = null) { | |||
| function cachedListSources($data = null) { | |||
There was a problem hiding this comment.
Won't this break a pile of backwards compatibility?
|
Seems like there are a bunch of other changes that are not part of the original pull request in here as well. Putting things on separate branches makes the pull requests work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hello CakePHP team.
While switching to the JsHelper, which is great to optimize the javascript code.
I had a problem with string bufferised from a requested action : the two requests (main one [http] and second one [requested] ) have each their buffer and it's not shared.
So some Js strings from requested ones are not in the main output.
I guess it's a known beahvior (each request have their own helpers). But if you consider to change this (at least for the Js Helper buffer), here is a patch to do this :
At the end, the "main" JsHelper collected all the buffers in one and can output it.